Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node.js Runtime stack #402

Closed
wants to merge 1 commit into from
Closed

Update Node.js Runtime stack #402

wants to merge 1 commit into from

Conversation

azatsarynnyy
Copy link
Contributor

What does this PR do?:

Summarize the changes. Are any stacks or samples added or updated?

  • update schema to 2.2.0;
  • use https protocol for the nodejs devfile

Which issue(s) this PR fixes:

Link to github issue(s)
eclipse-che/che#22869

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

https://workspaces.openshift.com/#https://raw.githubusercontent.com/azatsarynnyy/registry/patch-1/stacks/nodejs/2.2.0/devfile.yaml

@azatsarynnyy azatsarynnyy requested review from BethGriggs and a team as code owners May 23, 2024 11:28
@openshift-ci openshift-ci bot requested review from johnmcollier and thepetk May 23, 2024 11:28
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: azatsarynnyy
Once this PR has been reviewed and has the lgtm label, please assign elsony for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 23, 2024

Hi @azatsarynnyy. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@azatsarynnyy
Copy link
Contributor Author

superseded by #403

@azatsarynnyy azatsarynnyy deleted the patch-1 branch May 23, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs Awaiting requested review from BethGriggs BethGriggs is a code owner

@johnmcollier johnmcollier Awaiting requested review from johnmcollier

@thepetk thepetk Awaiting requested review from thepetk

Assignees
No one assigned
Labels
needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@azatsarynnyy